Add UUID parameter to server firmware management handler #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 27, 2018 13:16
…clients Minor clenup issues fixed in WebSocketListener
…(locally test runs ok) Some logging added and timeouts increased (to be slightly greater than server shutdown timeout) to debug the issue
…tie requests to certain session
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
============================================
- Coverage 53.49% 53.48% -0.01%
- Complexity 812 813 +1
============================================
Files 180 180
Lines 3047 3053 +6
Branches 211 212 +1
============================================
+ Hits 1630 1633 +3
- Misses 1332 1337 +5
+ Partials 85 83 -2 |
TVolden
approved these changes
Jun 28, 2018
|
Hi Evgeny, Good catch, I totally forgot about that. See this is the power of open source software, the community. 😃 Thanks Thomas P.s. the reason I don't merge them right away is that GitHub has this wierd rule that I'm not allowed to merge a PR that have red marks, on a phone. |
|
Hi Thomas, You're totally right and that's why I am so glad to see activity grows on the Gitter. Kind regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add session UUID to server firmware management handler to be able to tie requests to certain session