Reimplement toString() by eu.chargetime.ocpp.utilities.MoreObjects.to StringHelper. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
==========================================
- Coverage 47.6% 45.2% -2.4%
Complexity 822 822
==========================================
Files 180 180
Lines 3525 3712 +187
Branches 355 355
==========================================
Hits 1678 1678
- Misses 1761 1948 +187
Partials 86 86 |
sumlin
changed the title
sumlin
force-pushed
the
feture/logsAndData
branch
from
03ddc7b
to
13e8c3f
Compare
sumlin
changed the title
TVolden
reviewed
Sep 3, 2018
| @Override | ||
| public String toString() { | ||
| // @Override | ||
| public String toString2() { |
There was a problem hiding this comment.
Oh, sorry, a few experiments.
| @@ -137,7 +137,7 @@ public void setTimestamp_calendarNow_timestampIsSet() { | |||
|
|
|||
| // When | |||
| request.setTimestamp(now); | |||
|
|
|||
| System.out.println(request.toString()); | |||
There was a problem hiding this comment.
Why do you have a printline here?
There was a problem hiding this comment.
Meh, some debug too... Sorry.
sumlin
force-pushed
the
feture/logsAndData
branch
from
13e8c3f
to
de35153
Compare
TVolden
approved these changes
Sep 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add custom Calendar.toString() into StringHelper.