Adding feature to LineChart: drawing image on nodal points

[ghost]

Sometimes circle in the nodal point is not enough customisation. Here implemented add-on to LineChart renderer which allows to draw custom UIImage instead of (or on top of) circle.

For using: switch DataSet.drawNodalImageEnabled=true, set image by DataSet.nodalImage=UIImage() and that's it. See demo project also.

#629

[ghost]

Guys, just tell me what am I doing wrong?

[liuxuan30]

I am lost. You are creating a PR, but you are asking what are you doing wrong? Is this PR you want to merge into ios-charts, or you just use it to create a project that has your problem?

[ghost]

Its a complete solution in PR, both changes in framework and in demo project. But nearly two weeks passed and there is no reaction neither in issue nor in Pull Requests section.

I mean, what should I do for PR to be accepted?

[danielgindi]

Accepting a PR involves code review, testing, and making the code cross
platform.

If you want to speed up the process- you are very welcome to port this code
to the Android counterpart and mention this PR there or vice versa :)
בתאריך יום ג׳, 5 בינו׳ 2016 ב-9:09 מאת AnatolyRosencrantz <
notifications@github.com>:

Its a complete solution in PR, both changes in framework and in demo
project. But nearly two weeks passed and there is no reaction neither in
issue nor in Pull Requests section.

I mean, what should I do for PR to be accepted?

—
Reply to this email directly or view it on GitHub
#641 (comment)
.

[liuxuan30]

My PRs are much older than yours, so.. be patient, especially it's not a bugfix. Lots of things to think about and review.. and people are busy, right:)

[gal-orlanczyk]

Hi is there any news about this feature?

[askielboe]

I believe its coming, but on standby atm. Meanwhile you can implement this PR on the master branch yourself. It's quite simple.

I did it for pie charts here: https://github.com/askielboe/ios-charts/tree/new-piechart-icons

[abjurato]

This feature is enabled by PR #1261