Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example playground #2364

Merged
merged 1 commit into from
Sep 25, 2017
Merged

add example playground #2364

merged 1 commit into from
Sep 25, 2017

Conversation

thierryH91200
Copy link
Contributor

@thierryH91200 thierryH91200 commented Apr 15, 2017

In addition to #2335 with markup

It's very good as tutorial

capture d ecran 2017-04-15 a 20 45 48

capture d ecran 2017-04-15 a 20 46 44

@liuxuan30
Copy link
Member

wow, thanks so much for your various help and contribution

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@f23e872). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2364   +/-   ##
=========================================
  Coverage          ?   19.67%           
=========================================
  Files             ?      112           
  Lines             ?    13720           
  Branches          ?        0           
=========================================
  Hits              ?     2700           
  Misses            ?    11020           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f23e872...8cbdf6d. Read the comment docs.

@pmairoldi
Copy link
Collaborator

This looks very cool! This should remove people asking why isn't there a swift demo.

@liuxuan30
Copy link
Member

@petester42 swift demo support involves several PRs, do you think we could manage to merge them to reduce @danielgindi overhead?

@pmairoldi pmairoldi self-assigned this Sep 15, 2017
@pmairoldi pmairoldi merged commit 8245f32 into ChartsOrg:master Sep 25, 2017
@thierryH91200
Copy link
Contributor Author

@petester42
II think this is not a good idea
this is swift 3
see pieChart
it is better to remove it
and I return a PR in swift 4

@thierryH91200
Copy link
Contributor Author

and other problem

Playgrounds

Known Issues
macOS playground execution may hang in the Running state with no results produced. This is more prevalent when changing pages. (32429211)
Workaround: Stop playground execution and rerun. If issue persists, close and reopen Xcode.

The liveTouchBar property of PlaygroundSupport is not supported. (31073754)

@pmairoldi
Copy link
Collaborator

Works for me. Swift 3 or 4 doesn't matter the interface of library is the same.

@pmairoldi
Copy link
Collaborator

If you want to make improvements then go ahead but it works with current master.

@thierryH91200
Copy link
Contributor Author

ok thanks

PeterSrost pushed a commit to sokol8/Charts that referenced this pull request Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants