Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify for Character Alert: characters is deprecated #2942

Merged
merged 1 commit into from
Nov 3, 2017

Conversation

suzuhiroruri
Copy link

character is deprecated.
As for "count character" code, delete "character" code.
You will delete deprecated alert.

modify for Character Alert
@liuxuan30
Copy link
Member

#2933 #2866

@liuxuan30 liuxuan30 changed the title modify for Character Alert modify for Character Alert: characters is deprecated Nov 2, 2017
@codecov-io
Copy link

Codecov Report

Merging #2942 into master will not change coverage.
The diff coverage is 28.57%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2942   +/-   ##
=======================================
  Coverage   19.64%   19.64%           
=======================================
  Files         113      113           
  Lines       13792    13792           
=======================================
  Hits         2709     2709           
  Misses      11083    11083
Impacted Files Coverage Δ
...ts/Renderers/XAxisRendererHorizontalBarChart.swift 0% <0%> (ø) ⬆️
Source/Charts/Renderers/YAxisRenderer.swift 55.94% <0%> (ø) ⬆️
Source/Charts/Renderers/XAxisRenderer.swift 59.07% <0%> (ø) ⬆️
...ts/Renderers/YAxisRendererHorizontalBarChart.swift 0% <0%> (ø) ⬆️
Source/Charts/Components/AxisBase.swift 48.73% <100%> (ø) ⬆️
Source/Charts/Charts/ChartViewBase.swift 24.23% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdbdaa6...021d5fb. Read the comment docs.

@liuxuan30 liuxuan30 merged commit 98552bb into ChartsOrg:master Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants