-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renderer protocol #2991
Renderer protocol #2991
Conversation
Updating fork from main
@liuxuan30 @petester42 @danielgindi There are changes here that pave the way to much larger changes to the framework which allow better type safety and less reliance on optionals. This is immediately followed by #2990. Once these two are approved, there will be more changes that can be quickly and easily made to greater improve the type safety and the use of optionals across the entire framework. |
Codecov Report
@@ Coverage Diff @@
## 4.0.0 #2991 +/- ##
========================================
Coverage ? 20.58%
========================================
Files ? 112
Lines ? 15431
Branches ? 256
========================================
Hits ? 3176
Misses ? 12218
Partials ? 37
Continue to review full report at Codecov.
|
This includes #2980 |
…enderer-chart-nonnil
@liuxuan30 After #2982 I think this one should be done next |
oops just read your comment. I would first start with diffs that are just two digits and later with the big ones. |
I'll just change the destination branch on the PR to 4.0.0. Also, I will start making more PRs into 4.0.0. I think some of my changes are big enough to warrant 4.0.0 even if they're not breaking. |
In the future I will create Issues and name the PRs after them. |
Continued in #3136 |
Renderer
andDataRenderer
are now protocols instead of classes.