Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for #3061 fix animation crash #3098

Merged
merged 1 commit into from
Dec 14, 2017
Merged

for #3061 fix animation crash #3098

merged 1 commit into from
Dec 14, 2017

Conversation

liuxuan30
Copy link
Member

@liuxuan30 liuxuan30 commented Dec 14, 2017

for #3061
revert animationUpdate() and animationEnd()
not trigger crash if subclass does nothing

revert animationUpdate() and animationEnd()
not trigger crash if subclass does nothing
@jjatie jjatie mentioned this pull request Dec 14, 2017
@codecov-io
Copy link

codecov-io commented Dec 14, 2017

Codecov Report

Merging #3098 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3098   +/-   ##
=======================================
  Coverage   19.46%   19.46%           
=======================================
  Files         113      113           
  Lines       15995    15995           
  Branches      248      248           
=======================================
  Hits         3114     3114           
  Misses      12845    12845           
  Partials       36       36
Impacted Files Coverage Δ
Source/Charts/Jobs/AnimatedViewPortJob.swift 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4a3d4f...f9a1456. Read the comment docs.

@liuxuan30 liuxuan30 merged commit f1acb2a into master Dec 14, 2017
@liuxuan30 liuxuan30 deleted the 3061 branch December 14, 2017 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants