Know when user is done interacting with graph #3599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3599 +/- ##
==========================================
- Coverage 29.94% 29.94% -0.01%
==========================================
Files 118 118
Lines 13793 13794 +1
==========================================
Hits 4130 4130
- Misses 9663 9664 +1
Continue to review full report at Codecov.
|
|
can you check if latest master fixed yours? |
|
fixed by #3612 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals ⚽
Easily be able to determine when a user stops interacting (highlighting) with a chart.
Implementation Details 🚧
I made the delegate method optional because it shouldn't have to be implemented. It's just an additional feature that some developers might find useful.
When a user stops a panGesture on a chart the delegate method will call back. This allows for the developer to know when the user stopped highlighting a graph. They can then update the chart accordingly. I used the feature to transition between a cubic (smooth) and linear graph as the user starts and stops highlighting a graph. Similar to the charts in the RobinHood App.
Testing Details 🔍
It's just an optinal callback so didn't add any tests.