Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong assignment to axisMaxLabels property #3721

Merged
merged 1 commit into from
Nov 1, 2018
Merged

Fix wrong assignment to axisMaxLabels property #3721

merged 1 commit into from
Nov 1, 2018

Conversation

ggirotto
Copy link
Contributor

Issue Link πŸ”—

#3656

Goals ⚽

Ensure that the max number of labels in the Y Axis is correct.

Implementation Details 🚧

I'm just changing the wrong assignment.

Testing Details πŸ”

I didn't added any tests, but if necessary please let me know

@codecov-io
Copy link

Codecov Report

Merging #3721 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3721   +/-   ##
=======================================
  Coverage   31.01%   31.01%           
=======================================
  Files         114      114           
  Lines       10482    10482           
=======================================
  Hits         3251     3251           
  Misses       7231     7231
Impacted Files Coverage Ξ”
Source/Charts/Components/AxisBase.swift 60.93% <0%> (ΓΈ) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 3b07904...d59b2d8. Read the comment docs.

@liuxuan30
Copy link
Member

liuxuan30 commented Nov 1, 2018

good catch! Thanks

@liuxuan30 liuxuan30 merged commit 69e433a into ChartsOrg:master Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants