Add lineJoinType and miterLimit parameters to LineChartDataSet (fixes #2180 ) #3797
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let users fix sharp edges the way they want, keeping default behaviour same as current.
Issue Link 🔗
#2180
Implementation Details 🚧
There is another PR that is made to solve same issue but it changes the default behaviour and actually also breaks line joins when
lineCapType
is not.round
. This PR is another way to solve that problem, but it also not ideal - multicolored line will not use introducedlineJoinType
property because of tricky way to draw that line (actually that tricky way leads to bad line whenlineCapType
is not.round
)