Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unnecessary #if statements and unified style to align with Xc… #3884

Merged
merged 2 commits into from
Mar 7, 2019
Merged

Removed unnecessary #if statements and unified style to align with Xc… #3884

merged 2 commits into from
Mar 7, 2019

Conversation

jjatie
Copy link
Collaborator

@jjatie jjatie commented Mar 5, 2019

Removed unnecessary #if statements and unified style to align with Xcode's indentation

@liuxuan30
Copy link
Member

liuxuan30 commented Mar 6, 2019 •
edited
Loading

why it's no longer needed for OSX and tvOS? We don't need NSUI any more as well? What's changed behind the scene?

@jjatie
Copy link
Collaborator Author

jjatie commented Mar 6, 2019

Those #ifs have not been used since I’ve started on the project. I left the ones that are.

@liuxuan30
Copy link
Member

that's weird. because those macro are used for NSUI I suppose at that time? anyway.

@liuxuan30 liuxuan30 merged commit b4e300a into master Mar 7, 2019
@liuxuan30 liuxuan30 deleted the cleanup-pound-if branch March 7, 2019 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuxuan30 liuxuan30 liuxuan30 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjatie @liuxuan30