Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds test support without cocoapods #500

Merged
merged 1 commit into from
Oct 25, 2015
Merged

Adds test support without cocoapods #500

merged 1 commit into from
Oct 25, 2015

Conversation

pmairoldi
Copy link
Collaborator

Addresses #414

Like #422 this does not use cocoapods as to not create an xcworkspace. For now this uses XCTest but could be moved to Quick and Nimble if everyone likes it better.

@danielgindi
Copy link
Collaborator

Looks good!
I think we should add tests for the beziers too, and add edge cases (viewport encloses beginning/end of a large dataset, instead of being fully zoomed out)
But this is a good start!

@pmairoldi
Copy link
Collaborator Author

For sure. I was just putting the infrastructure in place.

@danielgindi
Copy link
Collaborator

Can't auto-merge, I think it clashes with the tvOS project changes

@pmairoldi
Copy link
Collaborator Author

Alright. I'll rebase and make things work.

@pmairoldi
Copy link
Collaborator Author

That should fix it

danielgindi added a commit that referenced this pull request Oct 25, 2015
Adds test support without cocoapods
@danielgindi danielgindi merged commit 93d20e7 into ChartsOrg:master Oct 25, 2015
@danielgindi
Copy link
Collaborator

Compiles fine and runs just fine :-)

@pmairoldi pmairoldi deleted the tests branch October 25, 2015 16:41
@yas375
Copy link
Contributor

yas375 commented Oct 26, 2015

@petester42 thanks! 👍 🚀

@danielgindi
Copy link
Collaborator

How do we re-generate those images?

While adding rotation support to labels, I have removed some "predefined" values that were there to adjust drawing quirks. Now we control the drawing more accurately and do not need those. But things have changed on a pixel level and all tests fail :(

@pmairoldi
Copy link
Collaborator Author

In setup add record = true. An example can be seen here. It's in objective-c but it's the same thing.

@pmairoldi
Copy link
Collaborator Author

Possibly all test can have it written but set to no just to make it easier to understand.

@danielgindi
Copy link
Collaborator

danielgindi commented Oct 27, 2015 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants