-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds test support without cocoapods #500
Conversation
Looks good! |
For sure. I was just putting the infrastructure in place. |
Can't auto-merge, I think it clashes with the tvOS project changes |
Alright. I'll rebase and make things work. |
That should fix it |
Adds test support without cocoapods
Compiles fine and runs just fine :-) |
@petester42 thanks! 👍 🚀 |
How do we re-generate those images? While adding rotation support to labels, I have removed some "predefined" values that were there to adjust drawing quirks. Now we control the drawing more accurately and do not need those. But things have changed on a pixel level and all tests fail :( |
In |
Possibly all test can have it written but set to no just to make it easier to understand. |
Thanks :-)
|
Addresses #414
Like #422 this does not use cocoapods as to not create an xcworkspace. For now this uses
XCTest
but could be moved toQuick
andNimble
if everyone likes it better.