Fix jagged lines sticking out from behind data point circles #5031
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals ⚽
Prevent jagged lines from sticking out from behind the data points
Implementation Details 🚧
I tried subclassing the LineChartRenderer to override drawLinear() but it's difficult because
_xBounds
and_lineSegments
areinternal
protected.Because this disconnects each line segment, I limited it only to the case where there's a data point circle covering the line join. If we want to be stricter about that check, we could also make sure that the circle size is greater than the line width, and that the color of the circle is fully opaque.
I also have a fix for the case where the disjoint isn't covered up, see
[improve-jagged-lines-extra](https://github.com/gsbernstein/Charts/pull/1/files)
Testing Details 🔍