Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for rounded bar chart and grid edges #5109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

swatiyadav009
Copy link

Issue Link πŸ”—

Goals ⚽

Implementation Details 🚧

Testing Details πŸ”

@swatiyadav009
Copy link
Author

Please do check my open PR for rounded slices for PieChart as well.
Link - #5114

@gabors
Copy link

gabors commented Dec 10, 2023

@swatiyadav009 Love this PR, few comments / wishes however:

  • the corner radius is a percentage of the bar width, so it doesn't work for horizontal charts, as they end up with super rounded corners (see example, dataSet.cornerRadius = 0.1)
  • would it be possible to supply instead an absolute value for the corner radius in points?
image

@crash481
Copy link

  1. bottom of Bars also with CornerRadius, when usually it is only on top. Need to make for every edge
  2. Selection highlight without corners
Screenshot 2024-03-28 at 20 46 28

@gabors
Copy link

gabors commented Mar 28, 2024

I actually don't mind the rounded edges on the bottom but yes the lack of rounding on the highlighted back has been annoying.

@crash481
Copy link

@gabors it is popular design when bars in bottom starts without corner radius, and on the top corners is rounded

@crash481
Copy link

crash481 commented Mar 28, 2024

I made this pull request, both problems above is fixed
#5163

@gabors
Copy link

gabors commented Mar 28, 2024

Agreed it's better to have options.

@crash481
Copy link

@gabors oh, also your wish about implement corner radius in absolute values also there. ✌️

@gabors
Copy link

gabors commented Mar 28, 2024

@crash481 amazing. I can get rid of my fork then 😊

I'll test it out today. Thanks πŸ™

@gabors
Copy link

gabors commented Mar 28, 2024

@crash481 on a different subject. How did you add that popup value ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants