Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves build time by 30%, resolving issue 5123 "Charts Framework takes a long time to build" #5124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improves build time by 30%, resolving issue 5123 "Charts Framework takes a long time to build" #5124

wants to merge 1 commit into from

Commits on Nov 8, 2023

  1. Improves clean Debug build time by about 30%. 

    Resolves issue ChartsOrg#5123 "Charts framework takes a long time to build" (ChartsOrg#5123) by implementing the recommendations listed at the end of the issue:
- Set `Eager Linking` build setting to `Yes` for `Charts` framework target
- Set `Enable Module Verifier` build setting to `No` for `Debug` builds
- Set `Compilation Mode` to `Incremental` for `Debug` builds
- Add `-Xfrontend -warn-long-expression-type-checking=50` (or perhaps use `100`) to `OTHER_SWIFT_FLAGS` so the Swift compiler will emit warnings for expressions that take a long time to type-check. The number after the = is the number of milliseconds threshold, above which warnings will be emitted.
- Refactored the slow type-checking hotspots identified above in `ChartAnimationEasing.swift`, breaking out expressions which are slow to type-check into separate, quicker-to-type-check expressions.
    @drewsterb
    drewsterb committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    c7f6ad9 View commit details
    Browse the repository at this point in the history