Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop axis labels duplicating. #315 [Pending squash and cleanup] #648

Merged
merged 1 commit into from
Mar 17, 2016

Conversation

noais
Copy link
Contributor

@noais noais commented Jan 4, 2016

With one commit 👍

@noais noais changed the title Stop axis labels duplicating. #315 [Pending squash and cleanup] Stop axis labels duplicating. #315 [Pending squash and cleanup] Jan 4, 2016
@liuxuan30
Copy link
Member

I think you need to practice "squash into 1 commit" by creating test branch and simulate the normal cases. Like you have create several commits, and merge upstream master with latest commits into your test branch, and squash it into one based on the upstream master. It's too much burden if you manually copy paste the code. I tried to practice and make me familiar, but it sometimes hard to describe...

If you are using SourceTree, you could right click the latest commit, Rebase, and let it rebase the code on the latest commit.
In order to squash, you need to right click the commit before your first commit, and Rebase Interactively. There you have a squash option :-)

Just try click on the last commit from upstream master and rebase, and try some others to get some feeling.

@noais
Copy link
Contributor Author

noais commented Jan 5, 2016

The problem was my master branch wasn't correctly synchronised with the origin and I thought it was.
Thanks

@liuxuan30
Copy link
Member

you could make sure you don't touch master, just keep it sync with upstream

@pmairoldi
Copy link
Collaborator

Are there any cases where you would want values to be duplicated? I get why the code duplicates values but users usually would assume to not have repeating values like a real graph.

@liuxuan30
Copy link
Member

I guess we don't think too much but make it just a switch to not triggering the code? allowReapting is the idea, but not proper to be the name? :)

@noais
Copy link
Contributor Author

noais commented Jan 22, 2016

@petester42 people was asking to create allowRepeatedValues. So I created, but I can't see one example where I want to see repeated values.

@danielgindi danielgindi merged commit bb0527f into ChartsOrg:master Mar 17, 2016
@danielgindi
Copy link
Collaborator

@noais thank you!
I've adjusted the terminology for the better, and made this the new default behaviour.

@petester42 a case where people will want "repeating values" is for example when you want to show grid lines - while hiding the value labels - but you want to always have at least 5 grid lines on display. No matter how fractioned the value intervals are...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants