Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /twitchemotes/set/:setID endpoint #332

Closed
jupjohn opened this issue Jul 2, 2022 · 3 comments · Fixed by #465
Closed

Remove /twitchemotes/set/:setID endpoint #332

jupjohn opened this issue Jul 2, 2022 · 3 comments · Fixed by #465

Comments

@jupjohn
Copy link
Contributor

jupjohn commented Jul 2, 2022

Chatterino no longer makes use of the /twitchemotes/set/:setID endpoint provided by this API. Could this be removed?

@pajlada you might have metrics on external callers. I doubt anyone else is using it but would suck to drop it with 0 notice image

@pajlada
Copy link
Member

pajlada commented Jul 3, 2022

I don't have metrics, once we have metrics I would be more comfortable deprecating endpoints

@M4tthewDE
Copy link
Contributor

As it has been over 2 months since adding additional metrics, it might be a good time revisiting this issue.

@pajlada
Copy link
Member

pajlada commented Apr 4, 2023

I can confirm that there have been no requests to the /twitchemotes/set/:setID endpoint since we started tracking this, other than the requests I made just now to make sure it was being tracked

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants