Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /twitchemotes/ endpoints #465

Merged
merged 5 commits into from
Apr 8, 2023
Merged

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Apr 8, 2023

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

  • Remove /twitchemotes/ endpoints
  • Remove the unused twitchusername cache
  • Add changelog entry

Fixes #332

@pajlada
Copy link
Member Author

pajlada commented Apr 8, 2023

@M4tthewDE Could you review please?

@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Merging #465 (1f20275) into master (4fe8a81) will increase coverage by 1.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
+ Coverage   45.45%   46.70%   +1.25%     
==========================================
  Files         103       99       -4     
  Lines        3819     3691     -128     
==========================================
- Hits         1736     1724      -12     
+ Misses       2033     1918     -115     
+ Partials       50       49       -1     
Impacted Files Coverage Δ
cmd/api/main.go 0.00% <ø> (ø)
pkg/config/config.go 41.05% <ø> (-0.62%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@M4tthewDE
Copy link
Contributor

I believe the config option twitchemotes-emote-cache-duration can be removed as well.
Looks good to me other than that. 👍

@pajlada pajlada enabled auto-merge (squash) April 8, 2023 11:44
@pajlada pajlada merged commit 3225a43 into master Apr 8, 2023
@pajlada pajlada deleted the chore/remove-twitchemotes-endpoints branch April 8, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove /twitchemotes/set/:setID endpoint
3 participants