Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Original quality Twitter profile pictures. #131

Merged
merged 5 commits into from
Apr 24, 2021

Conversation

KararTY
Copy link
Contributor

@KararTY KararTY commented Apr 22, 2021

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Note: I've not tested this fix.

As per @leon-richardt's link on issue #130, Twitter recommends modifying the received URL to get a higher quality profile picture. This also works for users who haven't set a profile picture.

Closes #130

@leon-richardt
Copy link
Contributor

I think I would prefer doing this in api.go where the TwitterUserApiResponse is built

@KararTY
Copy link
Contributor Author

KararTY commented Apr 22, 2021

I think I would prefer doing this in api.go where the TwitterUserApiResponse is built

Good call!

internal/resolvers/twitter/api.go Outdated Show resolved Hide resolved
@zneix
Copy link
Collaborator

zneix commented Apr 22, 2021

For some reason this keeps returning 500 https://cdn.zneix.eu/GJ9NqAE.png

Nevermind the above, for some reason using my Bearer Token against Twitter API returned 500 with no content, regenerating the token helped fixing the issue.

Copy link
Collaborator

@zneix zneix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended 👍

sorry leon and karar, my setup was lidl

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM 👍

@pajlada pajlada enabled auto-merge (squash) April 24, 2021 11:52
@pajlada pajlada merged commit 131b902 into Chatterino:master Apr 24, 2021
@KararTY KararTY deleted the twitter-better-profile-picture branch April 24, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check if we can get a higher quality thumbnail from Twitter
4 participants