Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Twitch clips to Helix API #144

Merged
merged 26 commits into from
May 9, 2021
Merged

Migrate Twitch clips to Helix API #144

merged 26 commits into from
May 9, 2021

Conversation

zneix
Copy link
Collaborator

@zneix zneix commented May 7, 2021

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

We deprecated usage of dankeroni/gotwitch in favour of nicklaw5/helix.
Our strategy of managing app access token (which is required for Helix calls we use) is the following: request and set it upon custom handler initialization and then re-request it every 24 hours.

Breaking change:

We now require client secret for creating app access tokens - new env variable: CHATTERINO_API_TWITCH_CLIENT_SECRET
Renamed client id env variable for more consistency (CHATTERINO_API_CACHE_TWITCH_CLIENT_ID => CHATTERINO_API_TWITCH_CLIENT_ID).

@zneix zneix requested a review from pajlada May 7, 2021 11:35
@zneix zneix marked this pull request as ready for review May 7, 2021 16:40
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for the contribution!

@pajlada pajlada merged commit 0e7af8b into master May 9, 2021
@pajlada pajlada deleted the feature/migrate-to-helix branch May 9, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants