Added rich tooltips for 7tv emote links #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extra line detected Co-authored-by: Leon Richardt <leon.richardt@gmail.com>
Host now matches properly through the MatchesHost function Path still matches through the regex
pajlada
requested changes
Jun 6, 2021
There was a problem hiding this comment.
Overall looks good to me - I would want to proxy the thumbnail requests though. Once that's done, I'm happy to have this merged in. Should use the utils.FormatThumbnailURL on the current thumbnail format and it should be good, just have to figure out at a way to pass BaseURL to this resolver.
Please take a look at the commits I pushed to the PR too, I added some tests, changed the way the query is generated (using proper GQL variables now), standardized the 'check' function to use the same methods that FrankerFaceZ uses.
1 task
…tv-emote-resolver
Every attempt to decode either animated or static WEBP thumbnails fails, so even though we proxy thumbnails through our cache, it fails to provide the thumbnail for us
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
I've added a new custom resolver for 7tv emotes. It uses their GQL API.
Things left to do: