-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Helix for loading Emote Set info #175
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
force-pushed
the
fix/use-helix-for-getting-emote-set-info
branch
from
June 20, 2021 12:05
07ccf10
to
f97b4ec
Compare
zneix
previously requested changes
Jun 20, 2021
zneix
added
the
blocked
Something out of our power needs to change before proceeding with this issue
label
Jun 22, 2021
1 task
zneix
removed
the
blocked
Something out of our power needs to change before proceeding with this issue
label
Jun 28, 2021
pajlada
force-pushed
the
fix/use-helix-for-getting-emote-set-info
branch
from
July 3, 2021 10:12
80d8acb
to
70bb12c
Compare
zneix
approved these changes
Jul 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
…o multiple packages that may want to use the same client.
and without trailing slashes
pajlada
force-pushed
the
fix/use-helix-for-getting-emote-set-info
branch
from
July 3, 2021 13:09
a9a7095
to
81f4c1d
Compare
zneix
approved these changes
Jul 3, 2021
zneix
approved these changes
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
Changes:
/twitchemotes/sets/
endpoint was removed completely - it was never implemented nor usednicklaw/helix
API Client is now initialized incmd/api/main.go
and passed through to any users. This allows multiple packages to share the same client./twitchemotes/set/{setID}/
we only populate the bare minimum fields:channel_name
andchannel_id
. The rest of the fields are still part of the JSON response, just left to their default values (empty string/0/false)/internal/routes/
/twitchemotes/set/{setID}/
endpointCloses #170
Closes #174