Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Skip lilliput if below maxThumbnailSize #184

Merged
merged 4 commits into from
Jul 3, 2021
Merged

fix: Skip lilliput if below maxThumbnailSize #184

merged 4 commits into from
Jul 3, 2021

Conversation

KararTY
Copy link
Contributor

@KararTY KararTY commented Jun 27, 2021 •
edited
Loading

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

If image is below maxThumbnailSize, might as well just use the inputBuf.

zneix
zneix approved these changes Jul 2, 2021
View reviewed changes
Copy link
Collaborator

@zneix zneix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some changes to your pull request that don't change anything related to resizing - just cleaned up unnecessary indentation layer with early-out if we don't resize the image.

@zneix zneix requested a review from pajlada July 2, 2021 17:08
@pajlada pajlada merged commit 292442b into Chatterino:master Jul 3, 2021
@KararTY KararTY deleted the lilliput-pass-through branch July 3, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zneix zneix zneix approved these changes

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KararTY @pajlada @zneix