fix(twitter): respect routes to non-user pages #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leon-richardt
force-pushed
the
fix/respect-twitter-special-routes
branch
2 times, most recently
from
bd20ba8
to
c798b47
Compare
Prior to this commit, the Twitter user resolver attempted to resolve
pages such as
- twitter.com/home or
- twitter.com/explore
as a user page. This lead to 404s and 403s. With this commit, we define
a collection of known non-user pages that will not be considered as user
pages when encountered.
The list of pages was sourced by looking around the Twitter web
interface so it is probably not exhaustive. If you find additional
special pages, please append them to `nonUserPages`.
pajlada
approved these changes
Oct 9, 2021
There was a problem hiding this comment.
Looks good to me.
I went ahead and added some simple tests @leon-richardt - please let me know if you think it looks good.
Upon your approval I will go ahead and merge this PR.
|
My apologies, it would have been good practice to add tests. Your implementation looks good to me so it'd be fine to merge from my side 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Fixes #140.
Commit message: