Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SevenTV emote resolver #281

Merged
merged 1 commit into from
Mar 13, 2022
Merged

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Mar 13, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

The API url used for the SevenTV resolver was broken - this PR fixes this and adds a lot of tests to prevent this from happening again.

@codecov
Copy link

codecov bot commented Mar 13, 2022

Codecov Report

Merging #281 (9428edd) into master (e5e4d1a) will increase coverage by 2.56%.
The diff coverage is 70.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
+ Coverage   29.54%   32.10%   +2.56%     
==========================================
  Files          56       56              
  Lines        1723     1713      -10     
==========================================
+ Hits          509      550      +41     
+ Misses       1178     1130      -48     
+ Partials       36       33       -3     
Impacted Files Coverage Δ
internal/resolvers/seventv/emote_loader.go 80.21% <54.54%> (+21.80%) ⬆️
internal/resolvers/seventv/emote_resolver.go 100.00% <100.00%> (+100.00%) ⬆️
internal/resolvers/seventv/initialize.go 100.00% <100.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5e4d1a...9428edd. Read the comment docs.

@pajlada pajlada enabled auto-merge (squash) March 13, 2022 13:49
@pajlada pajlada merged commit ec8a83d into master Mar 13, 2022
@pajlada pajlada deleted the fix/fix-seventv-emote-resolving branch March 13, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant