Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Twitch.tv clip tests #283

Merged
merged 1 commit into from
Mar 13, 2022
Merged

Improve Twitch.tv clip tests #283

merged 1 commit into from
Mar 13, 2022

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Mar 13, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

@codecov
Copy link

codecov bot commented Mar 13, 2022

Codecov Report

Merging #283 (1ca4861) into master (a70c387) will increase coverage by 2.22%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
+ Coverage   32.10%   34.32%   +2.22%     
==========================================
  Files          56       56              
  Lines        1713     1707       -6     
==========================================
+ Hits          550      586      +36     
+ Misses       1130     1090      -40     
+ Partials       33       31       -2     
Impacted Files Coverage Δ
internal/resolvers/twitch/clip_loader.go 92.30% <50.00%> (+30.08%) ⬆️
internal/resolvers/twitch/clip_resolver.go 100.00% <100.00%> (+43.90%) ⬆️
internal/resolvers/twitch/initialize.go 100.00% <100.00%> (+100.00%) ⬆️
internal/resolvers/twitch/parse_clip_slug.go 100.00% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a70c387...1ca4861. Read the comment docs.

@pajlada pajlada merged commit a727d4c into master Mar 13, 2022
@pajlada pajlada deleted the chore/improve-twitch-tests branch March 13, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant