Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check now returns a context #287

Merged
merged 1 commit into from
Mar 19, 2022
Merged

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Mar 19, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

@pajlada
Copy link
Member Author

pajlada commented Mar 19, 2022

No actual functional changes here, so I haven't made sure that the context updating works as expected (given shadowed variables etc etc), will be tested in the wikipedia test improvement PR (#286 )

@pajlada pajlada enabled auto-merge (squash) March 19, 2022 14:06
@codecov
Copy link

codecov bot commented Mar 19, 2022

Codecov Report

Merging #287 (b63bd61) into master (eb848ec) will not change coverage.
The diff coverage is 89.18%.

@@           Coverage Diff           @@
##           master     #287   +/-   ##
=======================================
  Coverage   49.47%   49.47%           
=======================================
  Files          56       56           
  Lines        1706     1706           
=======================================
  Hits          844      844           
  Misses        828      828           
  Partials       34       34           
Impacted Files Coverage Δ
internal/resolvers/wikipedia/article_resolver.go 0.00% <0.00%> (ø)
internal/resolvers/twitter/resolver.go 23.52% <60.00%> (ø)
internal/resolvers/betterttv/emote_resolver.go 100.00% <100.00%> (ø)
internal/resolvers/frankerfacez/emote_resolver.go 100.00% <100.00%> (ø)
internal/resolvers/imgur/resolver.go 9.09% <100.00%> (ø)
internal/resolvers/seventv/emote_resolver.go 100.00% <100.00%> (ø)
internal/resolvers/twitch/clip_resolver.go 100.00% <100.00%> (ø)
internal/resolvers/youtube/channel_resolver.go 100.00% <100.00%> (ø)
internal/resolvers/youtube/video_resolver.go 100.00% <100.00%> (ø)
...ernal/resolvers/youtube/video_shorturl_resolver.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb848ec...b63bd61. Read the comment docs.

@pajlada pajlada merged commit 3370ed2 into master Mar 19, 2022
@pajlada pajlada deleted the feat/resolver-check-add-context-values branch March 19, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant