Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Imgur tests #289

Merged
merged 2 commits into from
Mar 20, 2022
Merged

Improve Imgur tests #289

merged 2 commits into from
Mar 20, 2022

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Mar 20, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

This also ensures that we handle bad api responses more

  • Improve imgur tests
  • add changelog entry

@codecov
Copy link

codecov bot commented Mar 20, 2022

Codecov Report

Merging #289 (c1820f7) into master (0362f87) will increase coverage by 3.72%.
The diff coverage is 97.14%.

@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
+ Coverage   53.03%   56.76%   +3.72%     
==========================================
  Files          57       57              
  Lines        1727     1737      +10     
==========================================
+ Hits          916      986      +70     
+ Misses        784      727      -57     
+ Partials       27       24       -3     
Impacted Files Coverage Δ
internal/resolvers/imgur/helpers.go 96.00% <50.00%> (+26.37%) ⬆️
internal/resolvers/imgur/initialize.go 100.00% <100.00%> (+100.00%) ⬆️
internal/resolvers/imgur/loader.go 100.00% <100.00%> (+24.48%) ⬆️
internal/resolvers/imgur/resolver.go 100.00% <100.00%> (+90.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0362f87...c1820f7. Read the comment docs.

@pajlada pajlada enabled auto-merge (squash) March 20, 2022 14:18
@pajlada
Copy link
Member Author

pajlada commented Mar 20, 2022

👍

@pajlada pajlada merged commit f435c3e into master Mar 20, 2022
@pajlada pajlada deleted the chore/improve-imgur-tests branch March 20, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant