Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SevenTV tests #294

Merged
merged 2 commits into from
Mar 26, 2022
Merged

Improve SevenTV tests #294

merged 2 commits into from
Mar 26, 2022

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Mar 26, 2022

  • Add changelog entry
  • Add tests for missing emote, bad response

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

@codecov
Copy link

codecov bot commented Mar 26, 2022

Codecov Report

Merging #294 (9948395) into master (937c2ec) will increase coverage by 0.46%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
+ Coverage   71.32%   71.79%   +0.46%     
==========================================
  Files          56       56              
  Lines        1681     1677       -4     
==========================================
+ Hits         1199     1204       +5     
+ Misses        457      451       -6     
+ Partials       25       22       -3     
Impacted Files Coverage Δ
internal/resolvers/seventv/emote_loader.go 89.65% <100.00%> (+9.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 937c2ec...9948395. Read the comment docs.

@pajlada pajlada enabled auto-merge (squash) March 26, 2022 19:32
@pajlada pajlada merged commit 13b901e into master Mar 26, 2022
@pajlada pajlada deleted the chore/more-7tv-testing branch March 26, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant