Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for resolvers without any tests #296

Merged
merged 2 commits into from
Mar 27, 2022
Merged

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Mar 27, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

@codecov
Copy link

codecov bot commented Mar 27, 2022

Codecov Report

Merging #296 (9d2f913) into master (f05cba0) will decrease coverage by 28.15%.
The diff coverage is 16.00%.

@@             Coverage Diff             @@
##           master     #296       +/-   ##
===========================================
- Coverage   72.08%   43.93%   -28.16%     
===========================================
  Files          56       96       +40     
  Lines        1673     3041     +1368     
===========================================
+ Hits         1206     1336      +130     
- Misses        447     1684     +1237     
- Partials       20       21        +1     
Impacted Files Coverage Δ
internal/db/pool.go 0.00% <ø> (ø)
internal/logger/context.go 0.00% <0.00%> (ø)
internal/logger/logger.go 0.00% <ø> (ø)
internal/routes/twitchemotes/set_loader.go 0.00% <0.00%> (ø)
internal/routes/twitchemotes/initialize.go 20.51% <20.51%> (ø)
...nternal/resolvers/livestreamfails/clip_resolver.go 34.78% <0.00%> (ø)
internal/twitchapiclient/client.go 0.00% <0.00%> (ø)
internal/resolvers/discord/initialize.go 100.00% <0.00%> (ø)
internal/resolvers/default/thumbnail_loader.go 0.00% <0.00%> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f05cba0...9d2f913. Read the comment docs.

@pajlada pajlada merged commit 564697f into master Mar 27, 2022
@pajlada pajlada deleted the chore/add-missing-tests branch March 27, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant