Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add youtube shorts URLs #299

Merged
merged 4 commits into from
Apr 9, 2022
Merged

Conversation

NotNotQuinn
Copy link
Contributor

@NotNotQuinn NotNotQuinn commented Apr 1, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Add support for shorts urls, such as https://www.youtube.com/shorts/nSW6scUfnFw
The ids are just normal youtube video ids, and if the id isnt a short it redirects to /watch?v=

@NotNotQuinn NotNotQuinn marked this pull request as ready for review April 1, 2022 16:26
@pajlada pajlada enabled auto-merge (squash) April 9, 2022 11:21
@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #299 (9a1ef2f) into master (a60f63d) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
+ Coverage   46.27%   46.32%   +0.05%     
==========================================
  Files          97       97              
  Lines        3043     3046       +3     
==========================================
+ Hits         1408     1411       +3     
  Misses       1612     1612              
  Partials       23       23              
Impacted Files Coverage Δ
internal/resolvers/youtube/helpers.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a60f63d...9a1ef2f. Read the comment docs.

@pajlada pajlada merged commit d40f458 into Chatterino:master Apr 9, 2022
@jupjohn jupjohn mentioned this pull request Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants