Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default resolver tests #300

Merged
merged 3 commits into from
Apr 23, 2022
Merged

Add default resolver tests #300

merged 3 commits into from
Apr 23, 2022

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Apr 3, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

@pajlada pajlada force-pushed the chore/defaultresolver-tests branch from 04010d1 to 3a03532 Compare April 23, 2022 19:15
@codecov
Copy link

codecov bot commented Apr 23, 2022

Codecov Report

Merging #300 (c90b16c) into master (d82b13a) will increase coverage by 2.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #300      +/-   ##
==========================================
+ Coverage   46.32%   48.45%   +2.13%     
==========================================
  Files          97       97              
  Lines        3046     3046              
==========================================
+ Hits         1411     1476      +65     
+ Misses       1612     1531      -81     
- Partials       23       39      +16     
Impacted Files Coverage Δ
pkg/utils/string.go 100.00% <100.00%> (ø)
internal/resolvers/default/link_resolver.go 38.05% <0.00%> (+11.19%) ⬆️
internal/resolvers/default/metafields.go 25.00% <0.00%> (+25.00%) ⬆️
internal/resolvers/default/link_loader.go 47.61% <0.00%> (+47.61%) ⬆️
internal/resolvers/default/model.go 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d82b13a...c90b16c. Read the comment docs.

@pajlada pajlada marked this pull request as ready for review April 23, 2022 19:21
@pajlada pajlada changed the title play around with default resolver tests Add default resolver tests Apr 23, 2022
@pajlada pajlada force-pushed the chore/defaultresolver-tests branch from ad4e0ed to c90b16c Compare April 23, 2022 19:36
@pajlada
Copy link
Member Author

pajlada commented Apr 23, 2022

Looks good to me

@pajlada pajlada enabled auto-merge (squash) April 23, 2022 19:41
@pajlada pajlada merged commit ff81073 into master Apr 23, 2022
@pajlada pajlada deleted the chore/defaultresolver-tests branch April 23, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant