Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link resolver crashing when provided url is invalid #311

Merged
merged 1 commit into from
Apr 23, 2022

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Apr 23, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

  • Fix crash if provided URL is broken

@pajlada pajlada force-pushed the fix/link-resolver-broken-url branch from fe1f79c to adfe692 Compare April 23, 2022 19:47
@codecov
Copy link

codecov bot commented Apr 23, 2022

Codecov Report

Merging #311 (adfe692) into master (ff81073) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #311      +/-   ##
==========================================
+ Coverage   48.45%   48.63%   +0.18%     
==========================================
  Files          97       97              
  Lines        3046     3047       +1     
==========================================
+ Hits         1476     1482       +6     
+ Misses       1531     1526       -5     
  Partials       39       39              
Impacted Files Coverage Δ
internal/resolvers/default/link_resolver.go 42.22% <100.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff81073...adfe692. Read the comment docs.

@pajlada pajlada merged commit 6cc1bb0 into master Apr 23, 2022
@pajlada pajlada deleted the fix/link-resolver-broken-url branch April 23, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant