feat: Enable static thumbnail generation on Windows #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KararTY
changed the title
Codecov Report
@@ Coverage Diff @@
## master #369 +/- ##
=======================================
Coverage 48.74% 48.74%
=======================================
Files 98 98
Lines 3159 3159
=======================================
Hits 1540 1540
Misses 1576 1576
Partials 43 43
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
KararTY
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
With this PR, I move @leon-richardt bespoke code from
thumbnail_unix.gotothumbnail.gonow that I've tested that this works just fine on Windows as well. (#312 should hopefully, eventually, eliminatethumbnail_unix.gocompletely if this PR goes well)I've also updated the GitHub Windows workflow, with @33KK's help, to install a hardcoded version of libvips. Why hardcoded? Because I could not figure out how to download the latest release of anything on GitHub without resorting to JSON parsing, and if you want to tear your hair out dealing with that manually by writing Powershell then that's very humbling.
In any case, 8.13.2 should be sufficient for Windows for now. People who host chatterino/api and/or build from source can use updated version without issue, unless there's breaking changes of course.
The build prerequisites snippet addition basically describes the GitHub workflow, and you do need to follow it. Doesn't matter if you are just building or just hosting Chatterino API.