feat: add tooltip support for PDF files #374
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
Closes #363.
This PR adds the concept of
ContentTypeResolver
s. With these, link resolving can be specialized by the response'sContent-Type
header value rather than by matching on the URL.This concept is then implemented for the content type
application/pdf
. For links with this content type, a tooltip with the following information is generated:Review Notes
Points a reviewer can focus on:
ContentTypeResolver
s are created and passed to theLinkLoader
?ContentTypeResolver
interface and thePDFResolver
implementation in thedefaultresolver
package. Would you rather have them elsewhere or in a subpackage?Testing
Links to test this with:
application/octet-stream
instead ofapplication/pdf
Content-Type
headerThank you!