Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore websites based on their hosts #405

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Dec 11, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Allow hosters to opt out of the Chatterino Link Resolver server-side

Not every hoster has the ability or resources to block our link resolver - this provides a simple way to block entire hosts.
Validation of ownership will be made manually when entries are added to the ignoredHosts map

What it looks like in Chatterino:
image

@pajlada pajlada linked an issue Dec 11, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Merging #405 (1a0ed12) into master (4636d0d) will increase coverage by 0.09%.
The diff coverage is 64.00%.

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage   45.42%   45.52%   +0.09%     
==========================================
  Files         100      100              
  Lines        3676     3699      +23     
==========================================
+ Hits         1670     1684      +14     
- Misses       1958     1966       +8     
- Partials       48       49       +1     
Impacted Files Coverage Δ
pkg/resolver/static_responses.go 10.60% <0.00%> (-0.69%) ⬇️
internal/resolvers/default/link_resolver.go 44.85% <70.58%> (+1.93%) ⬆️
internal/resolvers/default/initialize.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pajlada pajlada merged commit 2a030ac into master Dec 14, 2022
@pajlada pajlada deleted the feat/simple-ignore-hosts branch December 14, 2022 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow hosters to blocklist domains
1 participant