Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP Caching headers to links and thumbnails #417

Merged
merged 5 commits into from
Jan 23, 2023

Conversation

nuuls
Copy link
Contributor

@nuuls nuuls commented Jan 23, 2023

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Add Cache-Control: max-age=600 headers to Link Resolver and Thumbnail requests in order to make Cloudflare cache the responses. Left the TTL hardcoded on purpose to not interfere with #410.

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #417 (e136cd3) into master (aed6eee) will decrease coverage by 0.08%.
The diff coverage is 25.00%.

❗ Current head e136cd3 differs from pull request most recent head bcbabcb. Consider uploading reports for the commit bcbabcb to get more accurate results

@@            Coverage Diff             @@
##           master     #417      +/-   ##
==========================================
- Coverage   44.54%   44.47%   -0.08%     
==========================================
  Files         100      101       +1     
  Lines        3706     3712       +6     
==========================================
  Hits         1651     1651              
- Misses       2007     2013       +6     
  Partials       48       48              
Impacted Files Coverage Δ
pkg/cache/middleware.go 0.00% <0.00%> (ø)
internal/resolvers/default/initialize.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pajlada pajlada enabled auto-merge (squash) January 23, 2023 19:22
@pajlada pajlada merged commit 031b678 into Chatterino:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants