-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make resolver cache durations configurable #419
Make resolver cache durations configurable #419
Conversation
Codecov Report
@@ Coverage Diff @@
## master #419 +/- ##
==========================================
+ Coverage 44.49% 44.76% +0.26%
==========================================
Files 101 101
Lines 3713 3731 +18
==========================================
+ Hits 1652 1670 +18
Misses 2013 2013
Partials 48 48
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert the "header cache configuration" piece, they should be based on the provider's cache duration as stated in the TODO
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
Should be reviewed carefully, since wrong default cache durations can slip in easily.
There might be some caches that aren't of type
NewPostgreSQLCache
of which I might be unaware of.Closes #410