Add total requests prometheus metric #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
==========================================
- Coverage 44.66% 44.64% -0.03%
==========================================
Files 101 101
Lines 3739 3741 +2
==========================================
Hits 1670 1670
- Misses 2021 2023 +2
Partials 48 48
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Could you provide an example of what data is tracked? (i.e. what it looks like at the prometheus endpoint) |
Has more detailed stats and better URL parsing
|
I switched to the premade middleware, since it has better URL parsing and more detailed metrics. How the metrics look like: https://github.com/766b/chi-prometheus#what-do-you-get |
pajlada
requested changes
Jan 28, 2023
pajlada
approved these changes
Jan 28, 2023
pajlada
added a commit
that referenced
this pull request
Jan 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Adds an additional metric which tracks which top level routes are used how often. Not quiet happy with how the URL parsing works, but I was not able to find a better way with the std lib.
Closes #415