Add custom middleware to strip slashes #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #422 +/- ##
==========================================
- Coverage 44.76% 44.66% -0.10%
==========================================
Files 101 101
Lines 3731 3739 +8
==========================================
Hits 1670 1670
- Misses 2013 2021 +8
Partials 48 48
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Add additional documentation
…trip-trailing-slashes
pajlada
approved these changes
Jan 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Heavily inspired by the middleware provided by chi. The new custom solution also strips url-encoded trailing slashes.
This for example fixes mobile tiktok links (
https://vm.tiktok.com/ZMY8my6vq/), which are shared with a trailing slash by default. They didn't match to the link resolver router before the changes in this pr.EDIT
After some investigation, the true cause for this problem has been found. The middleware from chi uses the decoded URL to strip slashes. So it correctly strips both trailing "/" and trailing "%2F". It then uses the decoded URL to determine the correct handler for the route. Requests to
/link_resolver/{url}now contain a URL that is not encoded anymore, and chi fails to find the proper handler. The new middleware fixes this by assigning the encoded URL to the correct parameter.