Add Media Resolver

[nuuls]

Pull request checklist:

• CHANGELOG.md was updated, if applicable

Description

Add Tooltip-only Resolver for previously unsupported Media files. Particularly useful for file uploaders that do not show the file extension.

[codecov]

Codecov Report

Merging #427 (9ae43ed) into master (828a42d) will increase coverage by 1.03%.
The diff coverage is 89.13%.

@@            Coverage Diff             @@
##           master     #427      +/-   ##
==========================================
+ Coverage   44.62%   45.66%   +1.03%     
==========================================
  Files         101      103       +2     
  Lines        3742     3832      +90     
==========================================
+ Hits         1670     1750      +80     
- Misses       2024     2032       +8     
- Partials       48       50       +2     

Impacted Files	Coverage Δ
internal/resolvers/default/media_resolver.go	87.17% <87.17%> (ø)
internal/resolvers/default/link_resolver.go	45.62% <100.00%> (+0.76%)	⬆️
pkg/humanize/bytes.go	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[pajlada]

I would want to think a bit more what data makes sense to pass along to the user.
Size of the file is good, the humanize/bytes class makes sense for this & the tests are nice.
Type of file is good, I would like to know whether the link I'm clicking is going to be an audio file, a video file, or something else.
I don't personally care for the file extension (unless maybe as an extra to the type)
so maybe the tooltip can instead be simplified to two lines:
File type: Video (MP4)
Size: 13.4 MB

File type: Image (PNG)
Size: 2.3 MB

File Type: Text (JSON)?
Size: 0.3 KB

Some tests for the media resolver to ensure we test the various media types we thing are most important would be nice

[nuuls]

I removed the PathEscape here and it still works fine in Chatterino. Is there any actual need for it?

[pajlada]

It'll be necessary to make sure any already-escaped strings aren't unescaped by Chatterino.
When Chatterino parses this tooltip it runs a single unescape path.

If we don't call url.PathEscape here, our bad actor tooltip might look like this:
<div>tooltip: %3Cscript%20src=xd.js%3E</div>, and Chatterino's single unescape call will turn that into <div>tooltip: <script src=xd.js></div>

If we call url.PathEscape here, our bad actor tooltip would look like this:
%3Cdiv%3Etooltip: %253Cscript%2520src=xd.js%253E%3C%2Fdiv%3E and Chatterino would turn that into <div>tooltip: %3Cscript%20src=xd.js%3E</div> effectively 'nullifying' the bad actor's html tags.

This could be better solved by never sending actual HTML to Chatterino but this is where we're at 👯

[nuuls]

• Changed the Type and extension into a sinlge line as requested
• Removed handling for application/* types as it doesn't really fit the "Media" resolver and is just confusing
• Made file extension handling a bit more reliable and accurate (previous code was stolen from i.nuuls)
• Added tests for the Resolver

[pajlada]

It'll be necessary to make sure any already-escaped strings aren't unescaped by Chatterino.
When Chatterino parses this tooltip it runs a single unescape path.

If we don't call url.PathEscape here, our bad actor tooltip might look like this:
<div>tooltip: %3Cscript%20src=xd.js%3E</div>, and Chatterino's single unescape call will turn that into <div>tooltip: <script src=xd.js></div>

If we call url.PathEscape here, our bad actor tooltip would look like this:
%3Cdiv%3Etooltip: %253Cscript%2520src=xd.js%253E%3C%2Fdiv%3E and Chatterino would turn that into <div>tooltip: %3Cscript%20src=xd.js%3E</div> effectively 'nullifying' the bad actor's html tags.

This could be better solved by never sending actual HTML to Chatterino but this is where we're at 👯

[pajlada]

Just need that pathescape back, otherwise works as expected for me