-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 7TV V3 API #456
Use 7TV V3 API #456
Conversation
Codecov Report
@@ Coverage Diff @@
## master #456 +/- ##
==========================================
- Coverage 45.64% 45.46% -0.18%
==========================================
Files 103 103
Lines 3836 3818 -18
==========================================
- Hits 1751 1736 -15
+ Misses 2034 2032 -2
+ Partials 51 50 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nitpicks of the initial review, will take a more proper check this week
I would like an emote test back of a global emote
I added one. Though, note that "global emotes" are no different to regular emotes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected, thank you for the fix!
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
This PR updates the 7TV resolver to use the V3 API since V2 is deprecated. This fixes an issue of emote-images not appearing because a static template was used. Furthermore, all public mentions of "SevenTV" have been replaced to "7TV".