Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 7TV V3 API #456

Merged
merged 7 commits into from
Mar 30, 2023
Merged

Use 7TV V3 API #456

merged 7 commits into from
Mar 30, 2023

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Mar 26, 2023

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

This PR updates the 7TV resolver to use the V3 API since V2 is deprecated. This fixes an issue of emote-images not appearing because a static template was used. Furthermore, all public mentions of "SevenTV" have been replaced to "7TV".

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #456 (742ab9b) into master (13079e1) will decrease coverage by 0.18%.
The diff coverage is 90.90%.

❗ Current head 742ab9b differs from pull request most recent head ca22975. Consider uploading reports for the commit ca22975 to get more accurate results

@@            Coverage Diff             @@
##           master     #456      +/-   ##
==========================================
- Coverage   45.64%   45.46%   -0.18%     
==========================================
  Files         103      103              
  Lines        3836     3818      -18     
==========================================
- Hits         1751     1736      -15     
+ Misses       2034     2032       -2     
+ Partials       51       50       -1     
Impacted Files Coverage Δ
internal/resolvers/seventv/emote_loader.go 91.30% <90.62%> (+1.64%) ⬆️
internal/resolvers/seventv/initialize.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpicks of the initial review, will take a more proper check this week

I would like an emote test back of a global emote

internal/resolvers/seventv/data_test.go Show resolved Hide resolved
internal/resolvers/seventv/model.go Outdated Show resolved Hide resolved
@Nerixyz
Copy link
Contributor Author

Nerixyz commented Mar 27, 2023

I would like an emote test back of a global emote

I added one. Though, note that "global emotes" are no different to regular emotes.

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, thank you for the fix!

@pajlada pajlada enabled auto-merge (squash) March 30, 2023 11:14
@pajlada pajlada merged commit c2e082c into Chatterino:master Mar 30, 2023
@Nerixyz Nerixyz deleted the refactor/seventv-v3 branch March 30, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants