Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle broken YouTube URLs #488

Merged
merged 3 commits into from
Jun 10, 2023
Merged

Handle broken YouTube URLs #488

merged 3 commits into from
Jun 10, 2023

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Jun 10, 2023

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Fixes #485

@codecov
Copy link

codecov bot commented Jun 10, 2023

Codecov Report

Merging #488 (502a4aa) into master (1c4e013) will increase coverage by 0.19%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #488      +/-   ##
==========================================
+ Coverage   46.70%   46.90%   +0.19%     
==========================================
  Files          99       99              
  Lines        3691     3710      +19     
==========================================
+ Hits         1724     1740      +16     
- Misses       1918     1920       +2     
- Partials       49       50       +1     
Impacted Files Coverage Δ
internal/resolvers/youtube/video_resolver.go 90.00% <72.72%> (-10.00%) ⬇️
internal/resolvers/youtube/helpers.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pajlada pajlada requested a review from zneix June 10, 2023 13:59
@pajlada pajlada marked this pull request as ready for review June 10, 2023 13:59
@pajlada
Copy link
Member Author

pajlada commented Jun 10, 2023

In case you want to have a look @zneix - no worries if not. I'll merge it in myself in a few days if not

Copy link
Collaborator

@zneix zneix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections, good correction.

@pajlada pajlada merged commit a2021b3 into master Jun 10, 2023
@pajlada pajlada deleted the fix/handle-broken-youtube-urls branch June 10, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore ?feature=share at the end of youtube links
2 participants