Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secret ID and Source are the same #124

Closed
baruchiro opened this issue Jul 2, 2023 · 0 comments · Fixed by #125
Closed

Secret ID and Source are the same #124

baruchiro opened this issue Jul 2, 2023 · 0 comments · Fixed by #125
Assignees
@baruchiro

Comments

@baruchiro
Copy link
Contributor

BTW, I used the Source to give some extra information (and it's still unique), for example: git show 797f277509117a61b81eb97e1c6f509b5addf0c2:testdata/example.txt.

I think we should change the Secret.Description to this information, and move the description: Private Key to be under a new field called SecretType.

Originally posted by @baruchiro in #109 (comment)
@baruchiro baruchiro self-assigned this Jul 2, 2023
@baruchiro baruchiro linked a pull request Jul 2, 2023 that will close this issue
fix: unique ID for secrets #125
Merged
@baruchiro baruchiro mentioned this issue Jul 2, 2023
Merged
jossef pushed a commit that referenced this issue Jul 12, 2023
fix: unique id for secrets (#125)
9879b3b 
BREAKING CHANGES:
- new hashed `ID`
- `Description` changed to `RuleID`

Added:
- `--project-name` to `git` plugin
- `--project-name` to `filesystem` plugin

Close #124
Close #109 by implementing
#109 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baruchiro baruchiro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: unique ID for secrets Checkmarx/2ms
1 participant
@baruchiro