Feature/ast 11602 cli add ssh key scan create #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hmmachadocx
commented
Apr 12, 2022
hmmachadocx
commented
- Added -ssh-key flag to scan create
- Added unit tests and integration tests
- Code refactoring
- Added --ssh-key flag to scan create - Added unit tests and integration tests - Code refactoring
- Added missing private key in integration tests
hmmachadocx
requested review from
a team,
diogopcx and
tiagobcx
and removed request for
a team
- Fixed unit tests
- Added --ssh-key flag to scan create - Added unit tests and integration tests - Code refactoring
- Added missing private key in integration tests
- Fixed unit tests
ghost
force-pushed
the
feature/AST-11602_CLI_add_ssh_key_scan_create
branch
from
b28d35f
to
4be4f14
Compare
- Fixed unit tests and lint
- Fixed merge conflicts
- Fixed unit tests
- Added debug flag to check error in cicd
- print error cicd
- Fixed ssh test to create temp file to read ssh key
- Fix cicd integration tests
- Remove helping printed messages
- Add --ssh-key flag to project create and update project configuration with the ssh-key after project create - Unit tests and integration tests added
- Fixed lint errors
diogopcx
reviewed
Apr 18, 2022
- Added logs to check tests in CICD
- Added logs to check tests in CICD
- Removed private keys from project; - defer remove file
- added repository url to create project command;
- added unit tests and integration tests for project creation with ssh key
- Fix lint errors
- Fix lint errors
…ture/AST-11603_CLI_add_ssh_key_project_create # Conflicts: # test/integration/scan_test.go
- Fix unit tests
- Fixed integration tests
# Conflicts: # internal/commands/scan.go # internal/commands/scan_test.go # internal/params/flags.go # test/integration/scan_test.go
diogopcx
reviewed
Apr 28, 2022
- Clarify it is a private key required
diogopcx
approved these changes
Apr 28, 2022
thtri
pushed a commit
to thtri/ast-cli
that referenced
this pull request
Apr 19, 2024
* AST-11602 - CLI | Add SSH key to scan create command - Added --ssh-key flag to scan create - Added unit tests and integration tests - Code refactoring * AST-11602 - CLI | Add SSH key to scan create command - Added missing private key in integration tests * AST-11602 - CLI | Add SSH key to scan create command - Fixed unit tests * AST-11602 - CLI | Add SSH key to scan create command - Added --ssh-key flag to scan create - Added unit tests and integration tests - Code refactoring * AST-11602 - CLI | Add SSH key to scan create command - Added missing private key in integration tests * AST-11602 - CLI | Add SSH key to scan create command - Fixed unit tests * AST-11602 - CLI | Add SSH key to scan create command - Fixed unit tests and lint * AST-11602 - CLI | Add SSH key to scan create command - Fixed unit tests * AST-11602 - CLI | Add SSH key to scan create command - Added debug flag to check error in cicd * AST-11602 - CLI | Add SSH key to scan create command - print error cicd * AST-11602 - CLI | Add SSH key to scan create command - Fixed ssh test to create temp file to read ssh key * AST-11602 - CLI | Add SSH key to scan create command - Fix cicd integration tests * AST-11602 - CLI | Add SSH key to scan create command - Remove helping printed messages * AST-11603 - CLI | Add SSH key to project create command - Add --ssh-key flag to project create and update project configuration with the ssh-key after project create - Unit tests and integration tests added * AST-11603 - CLI | Add SSH key to project create command - Fixed lint errors * AST-11621 - CLI | Handle file filters when source is zip file - Added logs to check tests in CICD * AST-11621 - CLI | Handle file filters when source is zip file - Added logs to check tests in CICD * AST-11602 - CLI | Add SSH key to scan create command - Removed private keys from project; - defer remove file * AST-11603 - CLI | Add SSH key to project create command - added repository url to create project command; * AST-11603 - CLI | Add SSH key to project create command - added unit tests and integration tests for project creation with ssh key * AST-11603 - CLI | Add SSH key to project create command - Fix lint errors * AST-11603 - CLI | Add SSH key to project create command - Fix lint errors * AST-11603 - CLI | Add SSH key to project create command - Fix unit tests * AST-11603 - CLI | Add SSH key to project create command - Fixed integration tests * AST-11603 - CLI | Add SSH key to project create command - Clarify it is a private key required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.