fix: cst naming conflicts with built-in Object prototype props

fixes #1724
Chevrotain · Jan 3, 2022 · 93c78cd · 93c78cd
1 parent 9b472d4
commit 93c78cd
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 8 deletions.
diff --git a/packages/chevrotain/benchmark_web/README.md b/packages/chevrotain/benchmark_web/README.md
@@ -33,7 +33,7 @@ With the **Next** version (locally built version on current branch).
 
    - JS Engines, hotspots optimizations can slightly improve the results on concurrent runs.
 
-8. Inspect the `Relative Speed` column in `index_next.html`, e.g
+8. Inspect the `Relative Speed` column in `index_next.html`, e.g:
    - If it is 105%, there is likely a small performance improvement.
    - If it is 80% there is a large performance regression.
 

diff --git a/packages/chevrotain/benchmark_web/parsers/options.js b/packages/chevrotain/benchmark_web/parsers/options.js
@@ -12,6 +12,7 @@ const options = {
     }
   },
   current: {
+    // bundle: "../chevrotain.js",
     bundle: "https://unpkg.com/chevrotain/lib/chevrotain.js",
     parserConfig: {
       maxLookahead: 2,

diff --git a/packages/chevrotain/src/parse/parser/traits/recognizer_engine.ts b/packages/chevrotain/src/parse/parser/traits/recognizer_engine.ts
@@ -827,7 +827,7 @@ export class RecognizerEngine {
     this.RULE_OCCURRENCE_STACK.push(idxInCallingRule)
     this.RULE_STACK.push(shortName)
     // NOOP when cst is disabled
-    this.cstInvocationStateUpdate(fullName, shortName)
+    this.cstInvocationStateUpdate(fullName)
   }
 
   isBackTracking(this: MixedInParser): boolean {

diff --git a/packages/chevrotain/src/parse/parser/traits/tree_builder.ts b/packages/chevrotain/src/parse/parser/traits/tree_builder.ts
@@ -154,14 +154,10 @@ export class TreeBuilder {
     }
   }
 
-  cstInvocationStateUpdate(
-    this: MixedInParser,
-    fullRuleName: string,
-    shortName: string | number
-  ): void {
+  cstInvocationStateUpdate(this: MixedInParser, fullRuleName: string): void {
     const cstNode: CstNode = {
       name: fullRuleName,
-      children: {}
+      children: Object.create(null)
     }
 
     this.setInitialNodeLocation(cstNode)

diff --git a/packages/website/docs/changes/CHANGELOG.md b/packages/website/docs/changes/CHANGELOG.md
@@ -1,3 +1,9 @@
+## X.Y.Z (INSERT_DATE_HERE)
+
+#### Bug Fixes
+
+- [CST naming conflicts with built-in Object prototype props](https://github.com/Chevrotain/chevrotain/issues/1724)
+
 ## 9.1.0 (10-9-2021)
 
 #### Minor Changes