Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Merkle Blob into Data Layer #18711

Open
wants to merge 83 commits into
base: long_lived/datalayer_merkle_blob
Choose a base branch
from
Open

Integrate Merkle Blob into Data Layer #18711

wants to merge 83 commits into from

Conversation

fchirica
Copy link
Contributor

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

altendky and others added 30 commits May 14, 2024 09:56
@altendky
add chia.data_layer.util.merkle_blob
c7e697e
@altendky
raw node [de]serialization tests
2468b51
@altendky
NewTypes and other
b85c3fb
@altendky
just RawLeafMerkleNode.key_value
a622b13
@altendky
drop the root node type, internal or leaf might be the root
7079391
@altendky
trivial tree deserialization
c772ae6
@altendky
comment
7e0c897
@altendky
add MerkleBlob.get_lineage()
4a9e876
@altendky
store the index on the raw node objects (great? or not...?)
de2d8c0
@altendky
Merge branch 'main' into merkle_blob
b69d91d
@fchirica
Checkpoint.
a9fd907
@fchirica
Some linting.
a72a0c1
@fchirica
Some type checking.
b51e2a5
@fchirica
Lint.
b591345
@fchirica
Add proof of inclusion code.
8453b52
@fchirica
Fix test.
73e4222
@fchirica
Lint.
03f5119
@fchirica
Add free positions.
a78f0ed
@fchirica
Lint.
27b341e
@fchirica
Improve test.
f7bfa2c
@fchirica
Lint.:
62973f7
@fchirica
Lint.
64a4b94
@fchirica
Add upsert.
5b76402
@fchirica
Go with lower limits.
d1a2092
@fchirica
Apply Kyle's change.
827e86f
@altendky
Merge branch 'main' into fc.merkle_blob
96cb0a0
@fchirica
Lint.
6094e08
@altendky
ignore astuple mypy complaint
90c37a8
@altendky
add c_profile fixture
dda307a
@fchirica
Add cache.
146e4a3
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Oct 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@fchirica fchirica marked this pull request as ready for review November 5, 2024 01:54
@fchirica fchirica requested a review from a team as a code owner November 5, 2024 01:54
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

File Coverage Missing Lines
chia/data_layer/data_layer_util.py 84.2% lines 53-55
chia/data_layer/data_store.py 93.7% lines 207, 219, 249-251, 264, 311-312, 316-318, 382, 390, 410, 436, 790, 844, 877, 1035, 1042, 1079, 1087, 1345, 1386
chia/data_layer/download_data.py 66.7% lines 319
chia/data_layer/util/benchmark.py 0.0% lines 5, 15, 32, 37, 39, 41, 50-51, 53, 60, 66
chia/data_layer/util/merkle_blob.py 96.2% lines 244
Total Missing Coverage
581 lines 40 lines 93%

altendky
altendky requested changes Nov 12, 2024
View reviewed changes
chia/_tests/core/data_layer/test_data_rpc.py Show resolved Hide resolved
chia/_tests/core/data_layer/test_data_rpc.py Show resolved Hide resolved
chia/_tests/core/data_layer/test_data_rpc.py Show resolved Hide resolved
chia/_tests/core/data_layer/test_merkle_blob.py Outdated Show resolved Hide resolved
chia/data_layer/util/benchmark.py Show resolved Hide resolved
chia/data_layer/data_store.py Outdated Show resolved Hide resolved
chia/data_layer/data_store.py Show resolved Hide resolved
chia/data_layer/data_store.py Show resolved Hide resolved
chia/_tests/core/data_layer/test_data_store.py Outdated Show resolved Hide resolved
chia/_tests/core/data_layer/test_data_store.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altendky altendky altendky requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog coverage-diff DataLayer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fchirica @altendky