Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHIA-1732] Add Ruff specific linting rules #18845

Merged
merged 4 commits into from
Nov 14, 2024
Merged

[CHIA-1732] Add Ruff specific linting rules #18845

merged 4 commits into from
Nov 14, 2024

Conversation

Quexington
Copy link
Contributor

@Quexington Quexington commented Nov 8, 2024 •
edited
Loading

This PR adds support for the RUF error codes which contain some helpful linting suggestions as well as some meta capabilities like identifying unused #noqa directives.

@Quexington Quexington changed the title Add Ruff specific linting rules [CHIA-1732] Add Ruff specific linting rules Nov 8, 2024
@Quexington Quexington added Added Required label for PR that categorizes merge commit message as "Added" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Nov 8, 2024
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Nov 12, 2024
@Quexington Quexington force-pushed the quex.enable_ruff_specific_rules branch from 8f50032 to 53803e3 Compare November 13, 2024 22:43
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Nov 13, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Nov 13, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Nov 13, 2024
@Quexington Quexington marked this pull request as ready for review November 13, 2024 22:50
@Quexington Quexington requested a review from a team as a code owner November 13, 2024 22:50
altendky
altendky requested changes Nov 14, 2024
View reviewed changes
benchmarks/streamable.py Show resolved Hide resolved
chia/_tests/cmds/wallet/test_wallet.py Show resolved Hide resolved
chia/_tests/core/full_node/stores/test_block_store.py Outdated Show resolved Hide resolved
chia/_tests/core/full_node/stores/test_hint_store.py Outdated Show resolved Hide resolved
chia/_tests/core/full_node/test_full_node.py Show resolved Hide resolved
chia/_tests/environments/wallet.py Outdated Show resolved Hide resolved
chia/_tests/environments/wallet.py Outdated Show resolved Hide resolved
chia/_tests/wallet/dao_wallet/test_dao_wallets.py Outdated Show resolved Hide resolved
chia/util/db_wrapper.py Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
This was referenced Nov 14, 2024
Draft
Open
Merged
@github-actions GitHub Actions
Copy link
Contributor

File Coverage Missing Lines
chia/_tests/process_junit.py 0.0% lines 209, 286
chia/_tests/wallet/rpc/test_dl_wallet_rpc.py 50.0% lines 122
chia/cmds/check_wallet_db.py 50.0% lines 345
chia/farmer/farmer.py 50.0% lines 201
chia/full_node/full_node.py 66.7% lines 283, 293
chia/full_node/mempool_manager.py 50.0% lines 251
chia/introducer/introducer.py 0.0% lines 109
chia/pools/pool_wallet.py 0.0% lines 414
chia/pools/pool_wallet_info.py 0.0% lines 96
chia/seeder/dns_server.py 0.0% lines 83, 195, 477
chia/server/server.py 0.0% lines 505
chia/server/ws_connection.py 62.5% lines 671, 719, 724
chia/util/profiler.py 0.0% lines 138
chia/wallet/wallet_node.py 50.0% lines 429, 432
Total Missing Coverage
182 lines 21 lines 88%

@altendky altendky mentioned this pull request Nov 14, 2024
Open
2 tasks
@emlowe
Copy link
Contributor

emlowe commented Nov 14, 2024

pleasantly? surprised we didn't have more RUF006 dangling tasks errors in there.

@pmaslana pmaslana merged commit 604fc1f into main Nov 14, 2024
361 of 362 checks passed
@pmaslana pmaslana deleted the quex.enable_ruff_specific_rules branch November 14, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlowe emlowe emlowe approved these changes

@altendky altendky altendky approved these changes

Assignees
No one assigned
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Quexington @emlowe @altendky @pmaslana