My take on dialects, which I think is now uniform in interface with the run_program from stage_0

[prozacchiwawa]

May be controversial.

I made cuts needed to move some constants into a place where importing them would be possible from anywhere, improving dependency congestion.

Main visible differences:

• There is now a dialect_factories collection the end user can use to get sane dialects.
• Configuring a dialect to be a standard chia clvm runner is now a function that most python based dialects can use.
• A configure method on dialects allows implementation specific communication

As used in clvm_tools, it's now possible to

        ````
        backend = args.backend if args.backend is not None else "python"
        dialect = dialect_factories[backend](
            KEYWORD_TO_ATOM["q"],
            KEYWORD_TO_ATOM["a"],
            args.strict,
            to_sexp_f
        )

        cost, result = dialect.run_program(
            run_script, input_sexp, max_cost=max_cost, pre_eval_f=pre_eval_f)
        ````

The dialect object is factored out of global paths, so it at least owns all its own information.

[richardkiss]

Can you run black on all the .py files to standardize formatting?

pip install black
black clvm tests

[richardkiss]

Can you build this table algorithmically from OP_REWRITE?

[richardkiss]

Or vice-versa?

[richardkiss]

I'm not sure this constant is actually Chia dialect-specific.

[prozacchiwawa]

I included it there mainly to avoid another layer when resolving dependencies, but it does make sense to put this on a layer in between.

[richardkiss]

I think it's best to make clvm_rs an optional dependency. I expect that clvm_rs will eventually be completely standalone.

[richardkiss]

I know I originally wrote this file, but I'm wondering if maybe we should remove CLVMObjectType since it's not actually used anywhere (and maybe other unused things in this file). It doesn't seem that mypy's typing system is advanced enough to do what we need to do.

[prozacchiwawa]

Whoops these should be replaced with a dialect choice. Will fix that.