Skip to content

Commit

Permalink
Fix the click behavior for <tr> and <td> with [data-href] (go-gitea#1…
Browse files Browse the repository at this point in the history
  • Loading branch information
wxiaoguang authored and Stelios Malathouras committed Mar 28, 2022
1 parent d5fc21b commit d3c45af
Showing 1 changed file with 13 additions and 8 deletions.
21 changes: 13 additions & 8 deletions web_src/js/features/common-global.js
Original file line number Diff line number Diff line change
Expand Up @@ -119,14 +119,19 @@ export function initGlobalCommon() {
$($(this).data('target')).slideToggle(100);
});

// make table <tr> element clickable like a link
$('tr[data-href]').on('click', function () {
window.location = $(this).data('href');
});

// make table <td> element clickable like a link
$('td[data-href]').click(function () {
window.location = $(this).data('href');
// make table <tr> and <td> elements clickable like a link
$('tr[data-href], td[data-href]').on('click', function (e) {
const href = $(this).data('href');
if (e.target.nodeName === 'A') {
// if a user clicks on <a>, then the <tr> or <td> should not act as a link.
return;
}
if (e.ctrlKey || e.metaKey) {
// ctrl+click or meta+click opens a new window in modern browsers
window.open(href);
} else {
window.location = href;
}
});
}

Expand Down

0 comments on commit d3c45af

Please sign in to comment.